Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daml2ts: Support lookupByKey #3987

Merged
merged 2 commits into from
Jan 9, 2020
Merged

daml2ts: Support lookupByKey #3987

merged 2 commits into from
Jan 9, 2020

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Jan 8, 2020 •
edited
Loading

We'll add fetchByKey and exerciseByKey in a separate PR. We'll remove
the pseudo* methods in another PR after that one.

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This change is Reviewable

@hurryabit hurryabit requested review from a user January 8, 2020 16:29
ghost
ghost approved these changes Jan 8, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@hurryabit hurryabit force-pushed the daml2ts-lookup-by-key branch 2 times, most recently from bd034fd to ab2960e Compare January 8, 2020 16:34
@hurryabit hurryabit force-pushed the daml2ts-lookup-by-key branch from 84940c0 to 754a40d Compare January 8, 2020 17:00
@hurryabit
daml2ts: Support lookupByKey
ddc6720 
We'll add `fetchByKey` and `exerciseByKey` in a separate PR. We'll remove
the `pseudo*` methods in another PR after that one.

CHANGELOG_BEGIN
CHANGELOG_END
@hurryabit
daml2ts: make lookupByKey inaccessible for templates without key
249c9d8
@hurryabit hurryabit force-pushed the daml2ts-lookup-by-key branch from 754a40d to 249c9d8 Compare January 9, 2020 09:29
@hurryabit
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@mergify mergify bot merged commit 20ad526 into master Jan 9, 2020
@mergify mergify bot deleted the daml2ts-lookup-by-key branch January 9, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hurryabit