Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine: Small refactoring of partial transactions #3951

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

remyhaemmerle-da
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da commented Jan 6, 2020

This PR slightly refactors the PartialTransaction data structure.
It basically moves the roots field (which are the children node if PartialTransaction is seen as a tree) to the PartialTransaction context.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da force-pushed the partial-transaction branch 7 times, most recently from 8de3acf to 4246005 Compare January 7, 2020 09:28
@remyhaemmerle-da remyhaemmerle-da marked this pull request as ready for review January 7, 2020 09:29
@remyhaemmerle-da remyhaemmerle-da requested review from a user and gerolf-da January 7, 2020 09:29
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyhaemmerle-da remyhaemmerle-da changed the title small refactoring of partial transaction Engine: Small refactoring of partial transactions Jan 7, 2020
@remyhaemmerle-da remyhaemmerle-da force-pushed the partial-transaction branch 2 times, most recently from 5655cee to ea54174 Compare January 8, 2020 12:37
@remyhaemmerle-da remyhaemmerle-da added automerge component/daml-engine DAML-LF Engine & Interpreter labels Jan 8, 2020
@remyhaemmerle-da remyhaemmerle-da force-pushed the partial-transaction branch 2 times, most recently from a52e80c to 9a4c861 Compare January 9, 2020 17:06
@mergify mergify bot merged commit c0f387f into master Jan 9, 2020
@mergify mergify bot deleted the partial-transaction branch January 9, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/daml-engine DAML-LF Engine & Interpreter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant