Bump ghcide #3943
Merged
Bump ghcide #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
force-pushed
the
bump-ghcide
branch
3 times, most recently
from
f415291 to
4646844
Compare
cocreature
force-pushed
the
bump-ghcide
branch
from
4646844 to
37f3d3f
Compare
cocreature
requested review from
garyverhaegen-da,
hurryabit and
nickchapman-da
as code owners
cocreature
commented
Jan 3, 2020
| @@ -128,7 +127,7 @@ build_docs_folder path versions = do | |||
| -- maps, and here order matters. | |||
| let versions_json = versions | |||
| & map (\s -> "\"" <> s <> "\": \"" <> s <> "\"") | |||
| & List.join ", " | |||
| & List.intercalate ", " | |||
There was a problem hiding this comment.
I removed the dependency on MissingH since we already depend on enough other kitchen sink libraries and it doesn’t buy us anything.
aherrmann-da
reviewed
Jan 3, 2020
|
@aherrmann-da thanks! should be fixed now. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cocreature
force-pushed
the
bump-ghcide
branch
from
3d99082 to
2ee4b31
Compare
garyverhaegen-da
added a commit
that referenced
this pull request
Jan 6, 2020
I noticed all uses of this library had been removed by #3943, but the library itself wasn't.
Merged
garyverhaegen-da
added a commit
that referenced
this pull request
Jan 6, 2020
I noticed all uses of this library had been removed by #3943, but the library itself wasn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtags, if appropriateNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.