daml script-test choose free port #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was marked exclusive because it required access to port 6865. However, the test-runner now automatically chooses a free port at runtime.
cocreature
approved these changes
Jan 3, 2020
| @@ -93,6 +93,7 @@ object TestMain extends StrictLogging { | |||
| case None => | |||
| val (apiParameters, cleanup) = if (config.ledgerHost.isEmpty) { | |||
| val sandboxConfig = SandboxConfig.default.copy( | |||
| port = 0, // Automatically choose a free port. | |||
There was a problem hiding this comment.
I guess sandbox.port points to the resolved port instead of 0? Otherwise I don’t understand how we can connect.
There was a problem hiding this comment.
Yes, exactly. The SandboxServer object exposes the selected port. So, fortunately no need for portFile or the like.
There was a problem hiding this comment.
Great, thanks for the confirmation 👍
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically choose a free port in daml script runner. See #3918 (comment). The chosen port is exposed by the
SandboxServerobject and directly available to the test runner.No longer requires the test to be marked exclusive.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtags, if appropriateNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.