Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies to da_scala_library #3938

Merged
merged 49 commits into from
Jan 6, 2020

Conversation

aherrmann-da
Copy link
Contributor

@aherrmann-da aherrmann-da commented Jan 2, 2020

Enables rules_scala's unused dependency checker by setting the attribute unused_dependency_checker_mode = "error" and removes unused dependencies on da_scala_library targets. This avoids unnecessary dependencies which is better for parallel builds and caching.

Some targets had their deps attribute factored out to a compileDependencies variable or similar. This makes "unused dependency checker" warnings harder to fix, so they have been inlined.

da_scala_test has been handled in #3925.
da_scala_binary has been handled in #3937.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@aherrmann-da aherrmann-da force-pushed the scala-library-unused-deps branch 2 times, most recently from a51bf94 to c23d05d Compare January 2, 2020 16:52
@ghost
Copy link

ghost commented Jan 6, 2020

LGTM, wrt the daml-sdk library. Thank you!
I'll leave the approval to someone from runtime.

Copy link
Contributor

@stefanobaghino-da stefanobaghino-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for some reason I thought someone approved this already. 🙂

@aherrmann-da aherrmann-da merged commit f33e79c into master Jan 6, 2020
@aherrmann-da aherrmann-da deleted the scala-library-unused-deps branch January 6, 2020 17:14
remyhaemmerle-da added a commit that referenced this pull request Jan 18, 2020
This PR fix the navigator decencies that were remove a bit too eagerly in f33e79c (#3938)
mergify bot pushed a commit that referenced this pull request Jan 19, 2020
* Navigator: Fixes dependencies

This PR fix the navigator decencies that were remove a bit too eagerly in f33e79c (#3938)

* changelog

CHANGELOG_BEGIN
CHANGELOG_END

* formatting

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants