-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused dependencies to da_scala_library #3938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann-da
force-pushed
the
scala-library-unused-deps
branch
2 times, most recently
from
January 2, 2020 16:52
a51bf94
to
c23d05d
Compare
This reverts commit ab3eb1a.
aherrmann-da
force-pushed
the
scala-library-unused-deps
branch
from
January 6, 2020 13:00
c23d05d
to
eb7d42e
Compare
6 tasks
aherrmann-da
requested review from
gerolf-da,
leo-da,
rautenrieth-da,
S11001001,
SamirTalwar and
stefanobaghino-da
as code owners
January 6, 2020 13:55
LGTM, wrt the daml-sdk library. Thank you! |
stefanobaghino-da
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but for some reason I thought someone approved this already. 🙂
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables rules_scala's unused dependency checker by setting the attribute
unused_dependency_checker_mode = "error"
and removes unused dependencies onda_scala_library
targets. This avoids unnecessary dependencies which is better for parallel builds and caching.Some targets had their
deps
attribute factored out to acompileDependencies
variable or similar. This makes "unused dependency checker" warnings harder to fix, so they have been inlined.da_scala_test
has been handled in #3925.da_scala_binary
has been handled in #3937.Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tags, if appropriateNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.