websocket variant of query endpoint #3936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocket-service-improvement
- clients may not be in control of how query bodies are delivered to the server, so we should be agnostic in that respect
CHANGELOG_BEGIN - [JSON API - Experimental] WebSocket contract search at ``/contracts/searchForever``. See `issue #3936 <https://github.com/digital-asset/daml/pull/3936>`_. CHANGELOG_END
|
|
leo-da
approved these changes
Jan 15, 2020
ledger-service/http-json/src/main/scala/com/digitalasset/http/WebSocketService.scala
Outdated
Show resolved
Hide resolved
- thanks @leo-da for pointing it out
hurryabit
reviewed
Jan 16, 2020
| After submitting an ``Iou_Split`` exercise, which creates two contracts | ||
| and archives the one above, the same stream will eventually produce:: | ||
|
|
||
| { |
There was a problem hiding this comment.
This format differs from what you get from the /commands/exercise endpoint. Her you get something looking like
{
created: [C1, C2],
archived: [A1, A2]
}
There you'd instead get
[
{created: C1},
{created: C2},
{archived: A1},
{archived: A2}
]
I'd prefer if the encoding is the same for both endpoints. Since the /commands/exercise endpoint does not work with the first format, we need to use the second in both places. It would be nice if could keep the order of the events we don't filter out during consolidation for the /contracts/searchForever endpoint, but I don't consider it a hard requirement.
stefanobaghino-da
added
the
team/ledger-clients
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3880, fixes #3878. Obsoletes #3912 (by incorporation of most of its parts) for the purposes of the JSON API itself.
Major changes versus #3912 :
/contracts/searchexactly. That means no empty queries are allowed, and the filtering part is actually used./contracts/searchForeverto emphasize that this is not a stream of transactions, as discussed in Add streaming service for queries #3878.{errors, created, archived}, where all members are lists, rather than containing one contract per output object.Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtags, if appropriateNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.