Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json websocket service improvement #3912

Closed
wants to merge 5 commits into from
Closed

Json websocket service improvement #3912

wants to merge 5 commits into from

Conversation

lima-da
Copy link
Contributor

@lima-da lima-da commented Dec 19, 2019 •
edited
Loading

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@lima-da
Copy link
Contributor Author

lima-da commented Dec 19, 2019

This PR contains the following changes:

  1. Add integration tests for WebSocket handshake, and base case message flow
  2. Add WebsocketConfig that can be overwritten by run args (maxDuration,heartBeatPer)
  3. Changed endpoint from /transaction/connect to /transactions

Next step:
create domain.Transaction dedicated for webSocket, and allow client define offset through message, use ContractsFetch.acsFollowingAndBoundary as transaction source, not TransactionClient#getTransactions #3880

@lima-da lima-da added the wip-issue This issue is being worked on. Use draft PRs for work in progress PRs. label Dec 19, 2019
@lima-da lima-da closed this Dec 19, 2019
@lima-da
Copy link
Contributor Author

lima-da commented Dec 19, 2019

This was closed for now before we resolve decisions on #3878

@S11001001 S11001001 mentioned this pull request Jan 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-da leo-da Awaiting requested review from leo-da

@S11001001 S11001001 Awaiting requested review from S11001001

@bame-da bame-da Awaiting requested review from bame-da

Assignees
No one assigned
Labels
wip-issue This issue is being worked on. Use draft PRs for work in progress PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lima-da