Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ghcide #3865

Merged
merged 4 commits into from
Dec 17, 2019
Merged

Bump ghcide #3865

merged 4 commits into from
Dec 17, 2019

Conversation

cocreature
Copy link
Contributor

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

cocreature
cocreature commented Dec 16, 2019
View reviewed changes
compiler/damlc/tests/src/DA/Test/ShakeIdeClient.hs
@@ -584,8 +584,7 @@ goToDefinitionTests mbScenarioService = Tasty.testGroup "Go to definition tests"
expectGoToDefinition (foo,2,[2..4]) Missing -- " : "
expectGoToDefinition (foo,2,[9]) Missing -- "\n"
expectGoToDefinition (foo,2,[10]) Missing -- (out of range)
expectGoToDefinition (foo,3,[0..2]) (At (foo,3,0)) -- "foo"
expectGoToDefinition (foo,3,[3..5]) Missing -- " = "
expectGoToDefinition (foo,3,[0..5]) (At (foo,3,0)) -- "foo = "
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new behavior here actually makes more sense, we are still within the definition of foo at the equal sign so it makes sense for goto definition to point back to foo.

cocreature
cocreature commented Dec 16, 2019
View reviewed changes
compiler/damlc/tests/src/DA/Test/ShakeIdeClient.hs
@@ -645,13 +644,11 @@ goToDefinitionTests mbScenarioService = Tasty.testGroup "Go to definition tests"
, "baz = 10"
]
setFilesOfInterest [foo]
expectGoToDefinition (foo,2,[0..2]) (At (foo,2,0))
expectGoToDefinition (foo,2,[3..5]) Missing
expectGoToDefinition (foo,2,[0..5]) (At (foo,2,0))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@cocreature cocreature marked this pull request as ready for review December 16, 2019 15:42
aherrmann-da
aherrmann-da approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@cocreature cocreature merged commit c65f918 into master Dec 17, 2019
@cocreature cocreature deleted the bump-ghcide branch December 17, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da aherrmann-da approved these changes

@nickchapman-da nickchapman-da Awaiting requested review from nickchapman-da

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @aherrmann-da