Include package name in manifest file #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we generate the `depends` field in the ghc-pkg config file based on the file name of the DARs in the `dependencies` field in `daml.yaml`. This falls apart when you use the -o option to `daml build` since `ghc-pkg` will complain about missing packages. This PR adds the name to the manifest so that we can generate the `depends` field based on that but I’ll leave that change for a separate PR.
cocreature
added a commit
that referenced
this pull request
Dec 11, 2019
Previously, we derived this based on the DAR name which breaks if you use -o with rather confusing error messages. Now, we read it from the `Name` field in the manifest that we added in #3805.
6 tasks
cocreature
added a commit
that referenced
this pull request
Dec 11, 2019
Previously, we derived this based on the DAR name which breaks if you use -o with rather confusing error messages. Now, we read it from the `Name` field in the manifest that we added in #3805. CHANGELOG_BEGIN - [DAML Compiler] Fix an issue where transitive package dependencies resulted in packages not being found, if the DAR name was changed with `-o`. CHANGELOG_END
cocreature
added a commit
that referenced
this pull request
Dec 11, 2019
* Fix package names in depends field in pkg configs Previously, we derived this based on the DAR name which breaks if you use -o with rather confusing error messages. Now, we read it from the `Name` field in the manifest that we added in #3805. CHANGELOG_BEGIN - [DAML Compiler] Fix an issue where transitive package dependencies resulted in packages not being found, if the DAR name was changed with `-o`. CHANGELOG_END * Fix package dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we generate the
dependsfield in the ghc-pkg config filebased on the file name of the DARs in the
dependenciesfield indaml.yaml. This falls apart when you use the -o option todaml buildsinceghc-pkgwill complain about missing packages.This PR adds the name to the manifest so that we can generate the
dependsfield based on that but I’ll leave that change for aseparate PR.
See https://github.com/digital-asset/daml/blob/master/compiler/damlc/daml-compiler/src/DA/Daml/Compiler/Dar.hs#L289
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtags, if appropriateNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.