-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert match #3795
Merged
Merged
Convert match #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, elminate lens and attoparsesec packages and groups.
hurryabit
reviewed
Dec 9, 2019
ghost
force-pushed
the
convert-match
branch
2 times, most recently
from
December 9, 2019 22:28
5c7cbc8
to
df0788c
Compare
ghost
marked this pull request as ready for review
December 9, 2019 22:34
ghost
force-pushed
the
convert-match
branch
2 times, most recently
from
December 10, 2019 00:44
2af48cb
to
d52281e
Compare
cocreature
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, a couple of the rules aren’t properly translated to DAML but that should be easy to fix.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dlint to include the GHC version of "match rules". Tests affected by the newly enabled diagnostics are updated to expect them. Depends on PR digital-asset/hlint#40.