Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert match #3795

Merged
4 commits merged into from
Dec 10, 2019
Merged

Convert match #3795

4 commits merged into from
Dec 10, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 9, 2019

This PR updates dlint to include the GHC version of "match rules". Tests affected by the newly enabled diagnostics are updated to expect them. Depends on PR digital-asset/hlint#40.

@ghost ghost requested review from hurryabit and cocreature December 9, 2019 20:46
Also, elminate lens and attoparsesec packages and groups.
@ghost ghost force-pushed the convert-match branch from 74888ac to 8e95444 Compare December 9, 2019 21:08
@ghost ghost force-pushed the convert-match branch 2 times, most recently from 5c7cbc8 to df0788c Compare December 9, 2019 22:28
@ghost ghost marked this pull request as ready for review December 9, 2019 22:34
@ghost ghost force-pushed the convert-match branch 2 times, most recently from 2af48cb to d52281e Compare December 10, 2019 00:44
@ghost ghost force-pushed the convert-match branch from d52281e to 12a39d8 Compare December 10, 2019 01:47
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, a couple of the rules aren’t properly translated to DAML but that should be easy to fix.

compiler/damlc/daml-ide-core/dlint.yaml Show resolved Hide resolved
compiler/damlc/daml-ide-core/dlint.yaml Show resolved Hide resolved
compiler/damlc/daml-ide-core/dlint.yaml Outdated Show resolved Hide resolved
compiler/damlc/daml-ide-core/dlint.yaml Outdated Show resolved Hide resolved
compiler/damlc/daml-ide-core/dlint.yaml Outdated Show resolved Hide resolved
compiler/damlc/daml-ide-core/dlint.yaml Outdated Show resolved Hide resolved
compiler/damlc/tests/daml-test-files/MaybeCompat.daml Outdated Show resolved Hide resolved
stack-snapshot.yaml Show resolved Hide resolved
@ghost ghost merged commit ab7c579 into master Dec 10, 2019
@ghost ghost deleted the convert-match branch December 10, 2019 13:24
@cocreature cocreature mentioned this pull request Dec 10, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants