Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docs live-preview.sh script #3789

Merged
merged 1 commit into from
Dec 10, 2019
Merged

fix docs live-preview.sh script #3789

merged 1 commit into from
Dec 10, 2019

Conversation

garyverhaegen-da
Copy link
Contributor

pipenv is broken on current master as of #3366, as it invokes a Python
in a subshell that does not have access to virtualenv.

cocreature
cocreature approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am a bit confused since I’m fairly sure that I tested this last week and it worked for me. Is this specific to MacOS?

@garyverhaegen-da
Copy link
Contributor Author

I do not think it is specific to macOS (I'll try to test that), but the virtualenv dependency is only used to initialize a new virtualenv, so if you had run the command with a previous (working) commit, it may still work for you because you still had one under ~/.local/share/virtualenvs and it can use that.

@cocreature
Copy link
Contributor

Thanks for the explanation!

@garyverhaegen-da
fix docs live-preview.sh script
558ebd9 
pipenv is broken on current master as of #3366, as it invokes a Python
in a subshell that does not have access to virtualenv.
@garyverhaegen-da
Copy link
Contributor Author

@cocreature I have no clue why but the check phase fails on Linux. Looking through the logs it appears it fails after setting up the virtualenv, while installing a dependency of wheel, the package used for the test.

I've disabled the check phase for now.

@cocreature
Copy link
Contributor

I’m fine with disabling the check phase.

@garyverhaegen-da garyverhaegen-da merged commit a995872 into master Dec 10, 2019
@garyverhaegen-da garyverhaegen-da deleted the fix-docs-live-preview branch December 10, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyverhaegen-da @cocreature