Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ghc-lib with exposed: False #3725

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Use ghc-lib with exposed: False #3725

merged 1 commit into from
Dec 4, 2019

Conversation

cocreature
Copy link
Contributor

@cocreature cocreature commented Dec 4, 2019

There are no DAML changes apart from bumping the ghc-lib revision to include the changes in #3725. I’ll make a proper ghc-lib release before merging this and update the URLs.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature marked this pull request as ready for review December 4, 2019 09:59
@cocreature cocreature requested review from a user and nickchapman-da December 4, 2019 09:59
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@mergify mergify bot merged commit 208cd23 into master Dec 4, 2019
@mergify mergify bot deleted the unexposed-ghc-lib branch December 4, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant