Simplify template desugaring #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplates This adapts the LF conversion to the new template desugaring introduced in our GHC fork. The guiding principle is that we use the typeclasses directly to avoid generating, typechecking and converting redundant code caused by indirections. I updated the template desugaring documentation so that is probably a good starting point for reviewing this.
ghost
approved these changes
Nov 29, 2019
cocreature
commented
Nov 29, 2019
| @@ -123,9 +123,14 @@ extractDocs extractOpts diagsLogger ideOpts fp = do | |||
|
|
|||
| (adts, md_templateInstances) = | |||
| partitionEithers . flip map filteredTyCons $ \adt -> | |||
| case getTemplateInstanceDoc adt of | |||
| case find (\td -> td_name td == ad_name adt) md_templates of | |||
There was a problem hiding this comment.
@associahedron I’ve hacked around this for now since I don’t want to clutter this PR too much but we should kill the generic templates support from daml-docs in a separate PR.
There was a problem hiding this comment.
Makes sense. I can do it if you don't mind.
hurryabit
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the LF conversion to the new template desugaring
introduced in our GHC fork. The guiding principle is that we use the
typeclasses directly to avoid generating, typechecking and converting
redundant code caused by indirections. I updated the template
desugaring documentation so that is probably a good starting point for
reviewing this.
See digital-asset/ghc#46 for the corresponding PR to GHC.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtags, if appropriateNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.