Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually run stack update #3590

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Manually run stack update #3590

merged 2 commits into from
Nov 22, 2019

Conversation

aherrmann-da
Copy link
Contributor

  • Add stack to Windows dev-env
  • Manually run stack update before build to avoid 
    user error (hTryLock: lock already exists: C:\Users\VssAdministrator\AppData\Roaming\stack\pantry\hackage\hackage-security-lock)

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@aherrmann
Add stack to dev-env
44f5b48
@aherrmann
Manually run stack update before build
e49f116 
To work around multiple concurrent attempts to take the
hackage-security-lock.
@garyverhaegen-da
Copy link
Contributor

Does that mean stack will be in path and therefore rules_haskell will use it and not try to install another one? I.e. this will not result in two different versions of stack stepping on each other?

@aherrmann-da
Copy link
Contributor Author

Does that mean stack will be in path and therefore rules_haskell will use it and not try to install another one? I.e. this will not result in two different versions of stack stepping on each other?

Yes, rules_haskell checks if stack is in PATH and only downloads a new one if not (or if it's too old).

cocreature
cocreature approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 02f806b into master Nov 22, 2019
@mergify mergify bot deleted the stack-lock branch November 22, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyverhaegen-da garyverhaegen-da garyverhaegen-da approved these changes

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aherrmann-da @garyverhaegen-da @cocreature @aherrmann