Add Universal Archive Reader to parse DARs and DALFs #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up DAR Reader errors.
leo-da
added
component/daml-lf
stephencompall-DA
approved these changes
Apr 10, 2019
| else Failure(UnsupportedFileExtension(f)) | ||
|
|
||
| sealed abstract class SupportedFileType(fileExtension: String) extends Serializable with Product { | ||
| def matchesFileExtension(f: File): Boolean = f.getName.endsWith(fileExtension) |
There was a problem hiding this comment.
Should this check be case-insensitive?
There was a problem hiding this comment.
it can be... I actually thought about this initially. But I believe our tools create DARs and DALFs with *.dar and *.dalf extensions and that is how it is supposed to be. But if you think the case is important, it is easy to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up DAR Reader errors.
See: #109
Pull Request Checklist