Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate API docs for DAML script and include them in the SDK docs #3568

Merged
merged 2 commits into from
Nov 21, 2019
Merged

Generate API docs for DAML script and include them in the SDK docs #3568

merged 2 commits into from
Nov 21, 2019

Conversation

cocreature
Copy link
Contributor

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature requested review from a user, hurryabit and aherrmann-da November 21, 2019 10:12
hurryabit
hurryabit approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you.

daml-script/daml/Daml/Script.daml Outdated Show resolved Hide resolved
@cocreature @hurryabit
Update daml-script/daml/Daml/Script.daml
1cd7a87 
Co-Authored-By: Martin Huschenbett <martin.huschenbett@posteo.me>
@cocreature cocreature merged commit ec5d832 into master Nov 21, 2019
@cocreature cocreature deleted the daml-script-api-docs branch November 21, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

@aherrmann-da aherrmann-da Awaiting requested review from aherrmann-da

@bame-da bame-da Awaiting requested review from bame-da

@nemanja-da nemanja-da Awaiting requested review from nemanja-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @hurryabit