Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreleased.rst #3547

Merged
merged 14 commits into from
Nov 20, 2019
Merged

Remove unreleased.rst #3547

merged 14 commits into from
Nov 20, 2019

Conversation

stefanobaghino-da
Copy link
Contributor

@stefanobaghino-da stefanobaghino-da commented Nov 20, 2019 •
edited
Loading

  • documents the new process in CONTRIBUTING.md
  • documents the new process in .github/pull_request_template.md
  • delete all lines from unreleased.rst and document the new process in that file
  • change the release script to not check for the unreleased.rst in release commits
  • document how to use git and awk so that anyone can get what used to be in unreleased.rst

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

garyverhaegen-da
garyverhaegen-da approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say people should be aware that PRs get squashed, but then it dawned on me the script will actually skip all CHANGELOG lines, not just the first, so that should work out.

cocreature
cocreature approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot for doing this!

release/RELEASE.md Outdated Show resolved Hide resolved
release/RELEASE.md Outdated Show resolved Hide resolved
unreleased.rst Show resolved Hide resolved
stefanobaghino-da added a commit that referenced this pull request Nov 20, 2019
@stefanobaghino-da
Address #3547 (comment)
0fe067c
@remyhaemmerle-da remyhaemmerle-da self-requested a review November 20, 2019 13:33
remyhaemmerle-da
remyhaemmerle-da approved these changes Nov 20, 2019
View reviewed changes
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Thank a lot.

cocreature
cocreature approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

CONTRIBUTING.md Outdated Show resolved Hide resolved
garyverhaegen-da
garyverhaegen-da reviewed Nov 20, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@oliverse-da
Copy link
Contributor

👍

stefanobaghino-da and others added 12 commits November 20, 2019 14:46
@stefanobaghino-da
Start working on getting rid of unreleased.rst
6ace361 
Document new process in CONTRIBUTING.md,
.github/pull_request_template.md and unreleased.rst (for good measure)

Report the previous changelog additions here so that they're not lost in
the mist of times.

CHANGELOG_BEGIN

- [DAML Stdlib] Added the ``NumericScale`` typeclass, which improves the type inference for Numeric literals, and helps catch the creation of out-of-bound Numerics earlier in the compilation process.

- [DAML Triggers] ``emitCommands`` now accepts an additional argument
  that allows you to mark contracts as pending. Those contracts will
  be automatically filtered from the result of ``getContracts`` until
  we receive the corresponding completion/transaction.

- [Navigator] Fixed a bug where Navigator becomes unresponsive if the ledger does not contain any DAML packages.

- [Ledger-API] Add field ``gen_map`` in Protobuf definition for ledger
  api values. This field is used to support generic maps, an new
  feature currently in development.  See issue
  #3356 for more details
  about generic maps.

  The Ledger API will send no messages where this field is set, when
  using a stable version of DAML-LF.  However the addition of this
  field may cause pattern-matching exhaustive warnings in the code of
  ledger API clients. Those warnings can be safely ignored until
  GenMap is made stable in an upcoming version of DAML-LF.

- [JSON API - Experimental] CLI configuration to enable serving static content as part of the JSON API daemon:
  ``--static-content "directory=/full/path,prefix=static"``
  This configuration is NOT recommended for production deployment. See issue #2782.

- [Extractor] The app can now work against a Ledger API server that requires client authentication. See `issue #3157 <https://github.com/digital-asset/daml/issues/3157>`__.
- [DAML Script] This release contains a first version of an experimental DAML script
   feature that provides a scenario-like API that is run against an actual ledger.
- [DAML Compiler] The default DAML-LF version is now 1.7. You can
  still produce DAML-LF 1.6 by passing ``--target=1.6`` to ``daml
  build``.

- [JSON API - Experimental] The database schema has changed; if using
  ``--query-store-jdbc-config``, you must rebuild the database by adding
  ``,createSchema=true``.
  See `issue #3461 <https://github.com/digital-asset/daml/pull/3461>`_.

- [JSON API - Experimental] Terminate process immediately after creating schema. See issue #3386.

- [DAML Stdlib] ``fromAnyChoice`` and ``fromAnyContractKey`` now take
  the template type into account.

CHANGELOG_END
@stefanobaghino-da
Document new release process to gather changelog additions
b1f170f
@stefanobaghino-da
Change the release script to ignore unreleased.rst
520cbab
@stefanobaghino-da
Remove spurious unreleased.rst lines
6077499
@stefanobaghino-da
Transition to use tags
136d58b
@stefanobaghino-da
Document new way to get changelog additions with tags
6b2aa5f
@stefanobaghino-da @garyverhaegen-da
Update release/RELEASE.md
6b529c3 
Co-Authored-By: Gary Verhaegen <gary.verhaegen@digitalasset.com>
@stefanobaghino-da
Address #3547 (comment)
1967b79
@stefanobaghino-da
Document correction process
7f871aa
@stefanobaghino-da
Add copyright header to unreleased.sh
4c59cfa
@stefanobaghino-da @garyverhaegen-da
Update CONTRIBUTING.md
f084426 
Co-Authored-By: Gary Verhaegen <gary.verhaegen@digitalasset.com>
@stefanobaghino-da
Modify CONTRIBUTING.md after @garyverhaegen-da's proposal
fc8b576
@mergify mergify bot merged commit 84e6064 into master Nov 20, 2019
@mergify mergify bot deleted the remove-unreleased-rst branch November 20, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyverhaegen-da garyverhaegen-da garyverhaegen-da approved these changes

@remyhaemmerle-da remyhaemmerle-da remyhaemmerle-da approved these changes

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stefanobaghino-da @oliverse-da @cocreature @garyverhaegen-da @remyhaemmerle-da