Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include contract ids in DAML script’s query #3546

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Include contract ids in DAML script’s query #3546

merged 1 commit into from
Nov 20, 2019

Conversation

cocreature
Copy link
Contributor

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

aherrmann-da
aherrmann-da approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit f94b832 into master Nov 20, 2019
@mergify mergify bot deleted the script-query branch November 20, 2019 11:07
hurryabit
hurryabit reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit left review comments

@aherrmann-da aherrmann-da aherrmann-da approved these changes

@bame-da bame-da Awaiting requested review from bame-da

@nemanja-da nemanja-da Awaiting requested review from nemanja-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cocreature @hurryabit @aherrmann-da