Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the docs for the visualization to the experimental section #3531

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Move the docs for the visualization to the experimental section #3531

merged 1 commit into from
Nov 19, 2019

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Nov 19, 2019 •
edited
Loading

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This change is Reviewable

bame-da
bame-da previously requested changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@bame-da bame-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the configs/pdf/index.rst for the PDF in sync with the main index.rst.

@bame-da
Copy link
Contributor

bame-da commented Nov 19, 2019

Maybe add a comment in index.rst so the next person does it straightaway

@cocreature
Copy link
Contributor

If we want them to be in sync, why do we have two? Can we not factor out the shared part?

@hurryabit hurryabit force-pushed the docs-visual-experimental branch from 9b04451 to 4cbf948 Compare November 19, 2019 15:05
cocreature
cocreature approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hurryabit
Copy link
Contributor Author

@bame-da I don't think adding a comment in index.rst helps. I would have completely missed it. We should rather have some automation that enforces that the files stay in sync.

@hurryabit hurryabit requested a review from bame-da November 19, 2019 16:39
@hurryabit hurryabit dismissed bame-da’s stale review November 19, 2019 16:40

I updated the files as indicated.

@hurryabit hurryabit merged commit e82630d into master Nov 19, 2019
@hurryabit hurryabit deleted the docs-visual-experimental branch November 19, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

@nemanja-da nemanja-da Awaiting requested review from nemanja-da

@bame-da bame-da Awaiting requested review from bame-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hurryabit @bame-da @cocreature