Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for DAML script and bundle it in the SDK #3527

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

cocreature
Copy link
Contributor

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature requested review from a user, hurryabit and aherrmann-da November 19, 2019 13:33
@cocreature cocreature force-pushed the daml-script-docs branch 3 times, most recently from 9e34786 to 28aa088 Compare November 19, 2019 13:55
@cocreature cocreature added this to the DAML Script milestone Nov 19, 2019
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you so much.

Apologies for the nit-picky comments. Too much time in academia... 😄

docs/source/daml-script/index.rst Show resolved Hide resolved
docs/source/daml-script/index.rst Show resolved Hide resolved
docs/source/daml-script/index.rst Show resolved Hide resolved
docs/source/daml-script/index.rst Show resolved Hide resolved
docs/source/daml-script/index.rst Show resolved Hide resolved
docs/source/daml-script/index.rst Show resolved Hide resolved
docs/source/daml-script/index.rst Show resolved Hide resolved
docs/source/daml-script/index.rst Show resolved Hide resolved
docs/source/daml-script/index.rst Show resolved Hide resolved
- daml-script
# script-dependencies-end
build-options:
- --target=1.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now remove this. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can’t, the corresponding PR is still failing on a bunch of tests. Working on fixing that atm 🙂

Copy link
Contributor Author

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving my wording!

- daml-script
# script-dependencies-end
build-options:
- --target=1.7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can’t, the corresponding PR is still failing on a bunch of tests. Working on fixing that atm 🙂

@mergify mergify bot merged commit 7deca90 into master Nov 19, 2019
@mergify mergify bot deleted the daml-script-docs branch November 19, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants