-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for DAML script and bundle it in the SDK #3527
Conversation
9e34786
to
28aa088
Compare
28aa088
to
24acc39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you so much.
Apologies for the nit-picky comments. Too much time in academia... 😄
- daml-script | ||
# script-dependencies-end | ||
build-options: | ||
- --target=1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can now remove this. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can’t, the corresponding PR is still failing on a bunch of tests. Working on fixing that atm 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for improving my wording!
- daml-script | ||
# script-dependencies-end | ||
build-options: | ||
- --target=1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can’t, the corresponding PR is still failing on a bunch of tests. Working on fixing that atm 🙂
8570eda
to
89fd97e
Compare
89fd97e
to
b260019
Compare
b260019
to
50f6dad
Compare
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.