Expose conversion from Ast.Type to iface.Type #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerolf-da
reviewed
Nov 18, 2019
| @@ -195,7 +195,7 @@ object InterfaceReader { | |||
| : InterfaceReaderError \/ ImmArraySeq[(Ref.Name, Type)] = | |||
| fields.toSeq traverseU { case (fieldName, typ) => type_(ctx, typ).map(x => fieldName -> x) } | |||
|
|
|||
| private def type_( | |||
| def type_( | |||
There was a problem hiding this comment.
@S11001001, @cocreature: what would be a bit more descriptive name for this?
There was a problem hiding this comment.
How about toIfaceType?
There was a problem hiding this comment.
Renamed to toIfaceType. Happy to change it to something else, I don’t care much for the name here.
cocreature
force-pushed
the
expose-iface-type
branch
from
671ccb1 to
06fa637
Compare
This allows me to get rid of the duplicated conversion logic for DAML script. The reason for why I can’t use the higher level APIs provided by the interface reader is that the type of the script identifier can be a function which is not serializable and therefore does not show up in the interface. However, I only want to translate the type of the argument of that function which is serializable.
cocreature
force-pushed
the
expose-iface-type
branch
from
06fa637 to
5938c3b
Compare
S11001001
requested changes
Nov 18, 2019
daml-lf/interface/src/main/scala/com/digitalasset/daml/lf/iface/reader/InterfaceReader.scala
Outdated
Show resolved
Hide resolved
…e/reader/InterfaceReader.scala Co-Authored-By: Stephen Compall <stephen.compall@daml.com>
S11001001
approved these changes
Nov 18, 2019
bame-da
pushed a commit
that referenced
this pull request
Nov 19, 2019
* Expose conversion from Ast.Type to iface.Type This allows me to get rid of the duplicated conversion logic for DAML script. The reason for why I can’t use the higher level APIs provided by the interface reader is that the type of the script identifier can be a function which is not serializable and therefore does not show up in the interface. However, I only want to translate the type of the argument of that function which is serializable. * Update daml-lf/interface/src/main/scala/com/digitalasset/daml/lf/iface/reader/InterfaceReader.scala Co-Authored-By: Stephen Compall <stephen.compall@daml.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows me to get rid of the duplicated conversion logic for DAML
script. The reason for why I can’t use the higher level APIs provided
by the interface reader is that the type of the script identifier can
be a function which is not serializable and therefore does not show up
in the interface. However, I only want to translate the type of the
argument of that function which is serializable.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.