Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add submitMustFail to DAML script #3510

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Add submitMustFail to DAML script #3510

merged 1 commit into from
Nov 18, 2019

Conversation

cocreature
Copy link
Contributor

This is useful for testing purposes and matches the function provided
in scenarios. We probably want to expose a variant of submitMustFail
that only succeeds if the SubmitFailure matches a specific condition
but I need to think a bit more about which API I want for that.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature
Add submitMustFail to DAML script
5827f2f 
This is useful for testing purposes and matches the function provided
in scenarios. We probably want to expose a variant of submitMustFail
that only succeeds if the SubmitFailure matches a specific condition
but I need to think a bit more about which API I want for that.
@cocreature cocreature requested review from a user and aherrmann-da November 18, 2019 15:23
ghost
ghost approved these changes Nov 18, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@cocreature cocreature added this to the DAML Script milestone Nov 18, 2019
@cocreature cocreature merged commit d776489 into master Nov 18, 2019
@cocreature cocreature deleted the daml-script-failure branch November 18, 2019 16:05
bame-da pushed a commit that referenced this pull request Nov 19, 2019
@cocreature @bame-da
Add submitMustFail to DAML script (#3510)
e6adcbf 
This is useful for testing purposes and matches the function provided
in scenarios. We probably want to expose a variant of submitMustFail
that only succeeds if the SubmitFailure matches a specific condition
but I need to think a bit more about which API I want for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da Awaiting requested review from aherrmann-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Daml Script
Development

Successfully merging this pull request may close these issues.
1 participant
@cocreature