Support seeding a DAML script from a JSON value #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the format for LF values that we already use elsewhere. There is one annoying part in this PR where I had to duplicate the logic for converting to the types used in the interface reader since it is not exposed but hopefully we can get rid of this soon in a separate PR. fixes #3470
cocreature
force-pushed
the
script-json-seed
branch
from
efe9f81 to
8529a1e
Compare
bame-da
pushed a commit
that referenced
this pull request
Nov 19, 2019
This uses the format for LF values that we already use elsewhere. There is one annoying part in this PR where I had to duplicate the logic for converting to the types used in the interface reader since it is not exposed but hopefully we can get rid of this soon in a separate PR. fixes #3470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the format for LF values that we already use elsewhere.
There is one annoying part in this PR where I had to duplicate the
logic for converting to the types used in the interface reader since
it is not exposed but hopefully we can get rid of this soon in a
separate PR.
fixes #3470
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.