Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rules_haskell #3473

Merged
merged 8 commits into from
Nov 15, 2019
Merged

Update rules_haskell #3473

merged 8 commits into from
Nov 15, 2019

Conversation

aherrmann-da
Copy link
Contributor

  • Updates rules_haskell
    Now supports rules_sh POSIX toolchain to manage Unix shell commands.
    Allows to avoid use_default_shell_env to improve hermeticity and caching.
  • Defines a Windows POSIX toolchain using dadew
  • Replace hpp by a stack_snapshot provided version.
    This is to ensure that the POSIX toolchain, which is used by haskell_cabal_library, is working.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@aherrmann-da aherrmann-da marked this pull request as ready for review November 15, 2019 09:04
aherrmann-da
aherrmann-da commented Nov 15, 2019
View reviewed changes
deps.bzl Outdated
rules_haskell_version = "f1323829e7e7cc1ea71013efe22466a6298a59b2"
rules_haskell_sha256 = "addd6b4d8d63fd5c3ed1a4a2a72f071397203474dbb9a9fe0487c917ac219d55"
rules_nixpkgs_version = "a169f54bfc48ad3ade9f46acac9fae7d493ad94b"
rules_haskell_version = "b8f4b6d8f3847edbcfd122f633e3a90e7ec9349d"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be pointed to master once tweag/rules_haskell#1143 is merged.

cocreature
cocreature approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@mergify mergify bot merged commit c994703 into master Nov 15, 2019
@mergify mergify bot deleted the rules-haskell branch November 15, 2019 10:50
bame-da pushed a commit that referenced this pull request Nov 19, 2019
@aherrmann-da @bame-da
Update rules_haskell (#3473)
67a7989 
* Update rules_haskell & rules_nixpkgs

* Define dadew POSIX toolchain on Windows

* Build hpp with stack and Cabal

* Replace Hazel hpp by @stackage hpp

* replace backslash by forward slash

* Cabal wrapper exclude bindist includes

* ghci-grpc patch fix missing argument

* Switch to rules_haskell master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aherrmann-da @cocreature @aherrmann