Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup conversions in DAML script and fix value translation #3467

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Cleanup conversions in DAML script and fix value translation #3467

merged 1 commit into from
Nov 14, 2019

Conversation

cocreature
Copy link
Contributor

This cleans up the remaining conversions in DAML script and fixes the
bug fixed in #3458 for DAML triggers by switching to the
ValueTranslator.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature requested review from a user and aherrmann-da November 14, 2019 12:31
@cocreature cocreature force-pushed the daml-script-conversion branch from 5b16c1e to 435c606 Compare November 14, 2019 13:23
@cocreature
Cleanup conversions in DAML script and fix value translation
4197cc8 
This cleans up the remaining conversions in DAML script and fixes the
bug fixed in #3458 for DAML triggers by switching to the
ValueTranslator.
@cocreature cocreature force-pushed the daml-script-conversion branch from 435c606 to 4197cc8 Compare November 14, 2019 13:24
aherrmann-da
aherrmann-da approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cocreature cocreature added this to the DAML Script milestone Nov 14, 2019
@cocreature cocreature merged commit d1ce573 into master Nov 14, 2019
@cocreature cocreature deleted the daml-script-conversion branch November 14, 2019 14:30
bame-da pushed a commit that referenced this pull request Nov 19, 2019
@cocreature @bame-da
Cleanup conversions in DAML script and fix value translation (#3467)
01d80be 
This cleans up the remaining conversions in DAML script and fixes the
bug fixed in #3458 for DAML triggers by switching to the
ValueTranslator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da aherrmann-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Daml Script
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @aherrmann-da