Cleanup conversions in DAML script submit #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ll leave the other commands such as Query for a separate PR. Part of this code can be shared with the DAML trigger runner but I’ll also leave that for a separate PR
hurryabit
approved these changes
Nov 13, 2019
| @@ -311,8 +215,7 @@ class Runner(dar: Dar[(PackageId, Package)], applicationId: ApplicationId) exten | |||
| } | |||
| case SVariant(_, "AllocParty", v) => { | |||
| v match { | |||
| case SRecord(_, _, vals) => { | |||
| assert(vals.size == 2) | |||
| case SRecord(_, _, vals) if vals.size == 2 => { | |||
There was a problem hiding this comment.
Should the exception we might throw below contain that we expected 2 fields in the record too? Same above.
There was a problem hiding this comment.
Good idea, fixed.
bame-da
pushed a commit
that referenced
this pull request
Nov 19, 2019
* Cleanup conversions in DAML script submit I’ll leave the other commands such as Query for a separate PR. Part of this code can be shared with the DAML trigger runner but I’ll also leave that for a separate PR * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ll leave the other commands such as Query for a separate PR.
Part of this code can be shared with the DAML trigger runner but I’ll
also leave that for a separate PR
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.