Amend the Node.js bindings Ledger API values representation #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finishes the work started in #324: - drops deprecated `name` in identifiers, adopting `moduleName` and `entityName` - use string to represent `timestamp`s to avoid a loss of precision - use string for `date`s too for consistency and future-proofness The work unconvered a quite serious bug caused by the lack of coverage on the validation of timestamps: the model was expecting timestamps to be of type timestamp, whereas in Ledger API values they are represented by numbers.
stefanobaghino-da
requested review from
francesco-da,
gerolf-da and
rautenrieth-da
Merged
| @@ -44,7 +44,7 @@ message Value { | |||
| // epoch is greater than that. Range: 0001-01-01T00:00:00Z to | |||
| // 9999-12-31T23:59:59.999999Z, so that we can convert to/from | |||
| // https://www.ietf.org/rfc/rfc3339.txt | |||
| sfixed64 timestamp = 9; | |||
| sfixed64 timestamp = 9 [jstype = JS_STRING]; | |||
There was a problem hiding this comment.
Why not use the [jstype = JS_STRING] annotation for int32 date = 14; below as well? Dates seem to be converted to strings manually in mapping/value.ts, whereas timestamps are converted to strings using the annotation.
There was a problem hiding this comment.
[jstype = JS_STRING] only works on 64-bit numeric types.
rautenrieth-da
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes the work started in #324:
namein identifiers, adoptingmoduleNameandentityNametimestamps to avoid a loss of precisiondates too for consistency and future-proofnessThe work unconvered a quite serious bug caused by the lack of coverage
on the validation of timestamps: the model was expecting timestamps to
be of type timestamp, whereas in Ledger API values they are represented
by numbers.
Pull Request Checklist