Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language: parse sdk version from manifest #3262

Merged
1 commit merged into from
Oct 28, 2019
Merged

language: parse sdk version from manifest #3262

1 commit merged into from
Oct 28, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2019

This is in preparation for the support of cross sdk imports, where we
need to know whether imports have different sdk versions or not.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

language: parse sdk version from manifest
c6641a5 
This is in preparation for the support of cross sdk imports, where we
need to know whether imports have different sdk versions or not.
@ghost ghost requested a review from hurryabit as a code owner October 28, 2019 15:57
cocreature
cocreature approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don’t understand why this is a prerequisite for cross-sdk upgrades. Imho that should only rely on package ids and the DAML-LF version.

@ghost
Copy link
Author

ghost commented Oct 28, 2019

not really cross-sdk-imports, but for the migrate command to set the correct compile options.

@ghost ghost merged commit d4f8db0 into master Oct 28, 2019
@ghost ghost deleted the sdkversion_from_manifest branch October 28, 2019 16:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cocreature