Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a first draft of documentation for DAML triggers #3181

Merged
merged 6 commits into from
Oct 15, 2019
Merged

Add a first draft of documentation for DAML triggers #3181

merged 6 commits into from
Oct 15, 2019

Conversation

cocreature
Copy link
Contributor

The API will still change in a bunch of ways but I’d rather get some
docs in place now and update them as we change things than not have
any docs at all.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

hurryabit
hurryabit approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you so much!

I left a few suggestions in #3183.

aherrmann-da
aherrmann-da approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Couple small comments

docs/source/triggers/index.rst Outdated Show resolved Hide resolved
docs/source/triggers/index.rst Show resolved Hide resolved
docs/source/triggers/index.rst Show resolved Hide resolved
docs/source/triggers/index.rst Show resolved Hide resolved
@cocreature
Add a first draft of documentation for DAML triggers
26aba3d 
The API will still change in a bunch of ways but I’d rather get some
docs in place now and update them as we change things than not have
any docs at all.
@cocreature
Fix path to daml.yaml
18d4cc8
@cocreature
s/bot/trigger/
7f87af9
@cocreature
fix source code markers
e08510c
@cocreature
Fix tests
11a8a74
@cocreature cocreature added this to the DAML Triggers milestone Oct 15, 2019
@cocreature @aherrmann-da
Update docs/source/triggers/index.rst
7dd12f2 
Co-Authored-By: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>
@cocreature cocreature merged commit dbddead into master Oct 15, 2019
@cocreature cocreature deleted the trigger-docs branch October 15, 2019 14:50
@S11001001 S11001001 mentioned this pull request Oct 21, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da aherrmann-da approved these changes

@hurryabit hurryabit hurryabit approved these changes

@bame-da bame-da Awaiting requested review from bame-da

@nemanja-da nemanja-da Awaiting requested review from nemanja-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DAML Triggers
Development

Successfully merging this pull request may close these issues.
3 participants
@cocreature @hurryabit @aherrmann-da