daml-lf: clean achive bazel build #3175
Conversation
remyhaemmerle-da
force-pushed
the
daml-lf-archive
branch
2 times, most recently
from
42563e4 to
7944297
Compare
remyhaemmerle-da
requested review from
bame-da,
gerolf-da,
hurryabit,
leo-da,
rautenrieth-da,
S11001001 and
stefanobaghino-da
as code owners
remyhaemmerle-da
force-pushed
the
daml-lf-archive
branch
from
2eb823a to
18fb403
Compare
daml-lf/archive/BUILD.bazel
Outdated
| tags = ["maven_coordinates=com.digitalasset:daml-lf-archive:__VERSION__"], | ||
| name = "daml_lf_archive_java_proto", | ||
| srcs = ["daml_lf_archive_java_proto_srcs"], | ||
| tags = ["maven_coordinates=com.digitalasset:daml-lf-%s-archive-java-proto:__VERSION__"], |
There was a problem hiding this comment.
What is the purpose of the %s here? Regardless of the details changing the maven coordinates will mean that we upload it to a different location so this should at the very least be documented in the release notes as users need to update this as well.
There was a problem hiding this comment.
My mistake. fixed
| @@ -100,10 +130,10 @@ da_scala_library( | |||
| name = "daml_lf_archive_reader", | |||
| srcs = glob(["src/main/scala/**/*.scala"]), | |||
| scalacopts = lf_scalacopts, | |||
| tags = ["maven_coordinates=com.digitalasset:daml-lf-archive-reader:__VERSION__"], | |||
| tags = ["maven_coordinates=com.digitalasset:daml-lf-archive-scala:__VERSION__"], | |||
There was a problem hiding this comment.
As for the other change, this is potentially breaking since users will have to update their references.
| - target: //daml-lf/archive:daml_lf_archive_protos_zip | ||
| - target: //daml-lf/archive:daml_lf_archive_java_proto | ||
| type: jar-lib | ||
| javadoc-jar: daml_lf_archive_java_proto_javadoc.jar |
There was a problem hiding this comment.
Do we no longer need the src-jar attribute here?
There was a problem hiding this comment.
I changed how the package is generated.
Like that the haskell releaser seems to find the sources without hint.
remy@remy-ThinkPad:~/work/daml$ ./ci/release.sh
...
Make dry run of release
step: release artifacts got stored in /tmp/tmp.t7KbRa77vq
remy@remy-ThinkPad:~/work/daml$ ls /tmp/tmp.t7KbRa77vq/com/digitalasset/daml-lf-archive-java-proto/100.13.29/
daml-lf-archive-java-proto-100.13.29.jar
daml-lf-archive-java-proto-100.13.29-javadoc.jar
daml-lf-archive-java-proto-100.13.29.pom
daml-lf-archive-java-proto-100.13.29-sources.jar
remy@remy-ThinkPad:~/work/daml$
You are right about the maven coordinate. Thanks for the careful review ! |
remyhaemmerle-da
force-pushed
the
daml-lf-archive
branch
from
18fb403 to
35801a6
Compare
remyhaemmerle-da
force-pushed
the
daml-lf-archive
branch
from
4b7e68e to
fe0c4f3
Compare
| tags = ["maven_coordinates=com.digitalasset:daml-lf-archive:__VERSION__"], | ||
| name = "daml_lf_archive_java_proto", | ||
| srcs = ["daml_lf_archive_java_proto_srcs"], | ||
| tags = ["maven_coordinates=com.digitalasset:daml-lf-archive-java-proto:__VERSION__"], |
There was a problem hiding this comment.
This still has different maven coordinates than before.
There was a problem hiding this comment.
I added to the release notes.
clean achive bazel build
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.