Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DAML-on-X IndexServer and Reference Server #3108

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Remove DAML-on-X IndexServer and Reference Server #3108

merged 4 commits into from
Oct 8, 2019

Conversation

gerolf-da
Copy link
Contributor

@gerolf-da gerolf-da commented Oct 4, 2019 •
edited
Loading

It is not needed anymore and can therefore be deleted.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@gerolf-da gerolf-da added the component/dlik DAML Ledger Integration Kit label Oct 4, 2019
@stefanobaghino-da
Copy link
Contributor

−2,529
thumb_satisfaction-face-meme-generator-52804776

@gerolf-da gerolf-da requested review from stefanobaghino-da and a user October 4, 2019 09:37
@gerolf-da gerolf-da requested a review from bame-da as a code owner October 4, 2019 11:29
@gerolf-da
Copy link
Contributor Author

@stefanobaghino-da: I bumped it up to -4k :)

@dajmaki: instead of the api-server-damlonx jar, this also publishes the sandbox jar as com.daml.ledger:ledger-api-server to maven. In the future this jar will not contain sandbox specifics, but for now it's identical.

@gerolf-da gerolf-da requested a review from dasormeter October 4, 2019 12:21
@stefanobaghino-da
Copy link
Contributor

@stefanobaghino-da: I bumped it up to -4k :)

Double the satisfaction

.
.

bame-da
bame-da reviewed Oct 4, 2019
View reviewed changes
docs/source/concepts/glossary.rst Outdated
@@ -425,7 +425,7 @@ DAML ledgers provide various guarantees about what you can expect from it, all l

When you're developing, you'll use `Sandbox <#sandbox>`__ as your ledger.

If you want to run DAML on a storage mechanism of your choice, you can use the :doc:`/daml-integration-kit/index` to help you do that.
If you want to run DAML on a storage mechanism of your choice, you can use one of the `supported platforms <https://daml.com>`__.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you would like to integrate DAML with a storage infrastructure not already in development (see daml.com <https://daml.com), please get in touch on Slack <https://damldriven.slack.com/sso/saml/start> in channel #daml-contributors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

bame-da
bame-da reviewed Oct 4, 2019
View reviewed changes
docs/source/index.rst
@@ -94,7 +94,7 @@ DAML SDK documentation
:caption: Experimental features

experimental/warning
daml-integration-kit/index
tools/ledger-api-test-tool/index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are adding a new docs page, but don't mention it in the release notes. Are you intentionally silently changing integration kit to api-test-tool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ledger-api-test-tool was previously a sub-link of the daml integration kit. the test tool itself works fine and is supported by us. therefore I'm fine that it is still listed in the docs.

@dasormeter
Copy link
Collaborator

image

@dasormeter
Copy link
Collaborator

@gerolf-da did you remove all the daml integration kit documentation here? i think we need to keep it, but in updated form

@gerolf-da
Copy link
Contributor Author

@gerolf-da did you remove all the daml integration kit documentation here? i think we need to keep it, but in updated form

@dasormeter: @dajmaki said that we can remove the docs completely.

@gerolf-da gerolf-da force-pushed the remove-damlonx-index-server branch from 59ab0bc to e96d222 Compare October 4, 2019 14:24
@gerolf-da gerolf-da force-pushed the remove-damlonx-index-server branch from e96d222 to d0deb0e Compare October 8, 2019 08:06
@gerolf-da gerolf-da merged commit 5592092 into master Oct 8, 2019
@gerolf-da gerolf-da deleted the remove-damlonx-index-server branch October 8, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bame-da bame-da bame-da left review comments

@rautenrieth-da rautenrieth-da Awaiting requested review from rautenrieth-da

@stefanobaghino-da stefanobaghino-da Awaiting requested review from stefanobaghino-da

@dasormeter dasormeter Awaiting requested review from dasormeter

Assignees
No one assigned
Labels
component/dlik DAML Ledger Integration Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gerolf-da @stefanobaghino-da @dasormeter @bame-da