Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove contract keys tests from semantic suite #3058

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Remove contract keys tests from semantic suite #3058

merged 1 commit into from
Sep 27, 2019

Conversation

stefanobaghino-da
Copy link
Contributor

  • removes contract keys tests from semantic suite
  • make contract keys tests multi-node aware

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@stefanobaghino-da
Copy link
Contributor Author

Will adjust release notes at a later point to avoid spurious conflicts.

gerolf-da
gerolf-da approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏
@oliverse-da will be happy :)

@stefanobaghino-da stefanobaghino-da force-pushed the remove-contract-keys-tests-from-semantic-suite branch from 87c4785 to 8e4dd49 Compare September 27, 2019 10:04
@stefanobaghino-da
Copy link
Contributor Author

Added the release note line after #3052 has been merged and an approval have been received. Thanks!

@stefanobaghino-da stefanobaghino-da merged commit 2955c49 into master Sep 27, 2019
@stefanobaghino-da stefanobaghino-da deleted the remove-contract-keys-tests-from-semantic-suite branch September 27, 2019 11:51
@oliverse-da
Copy link
Contributor

👏 👏 👏
@oliverse-da will be happy :)

I am indeed - thank you @stefanobaghino-da ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerolf-da gerolf-da

@dasormeter dasormeter

@mziolekda mziolekda

@oliverse-da oliverse-da

@rautenrieth-da rautenrieth-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanobaghino-da @oliverse-da @gerolf-da