Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ledger-service/http-json docs into docs.daml.com tree, summarize purpose #3012

Merged
merged 11 commits into from
Sep 24, 2019

Conversation

S11001001
Copy link
Contributor

Fixes #3004.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Copy link
Contributor

@leo-da leo-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 Many thanks for getting it done so quickly even!


::

$ daml-head sandbox --wall-clock-time --ledgerid MyLedger ./.daml/dist/quickstart-0.0.1.dar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the daml-head references to just daml.

@@ -213,9 +213,10 @@ quotes::
"Bob"

Unit
----
****

Represented as empty object ``{}``. Note that in JavaScript ``{} !==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backtick literals in this paragraph that are split across lines probably need to be joined back to start and end in the same line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just accidentally added an empty line between them; renders fine after reverting that d2ef790

@S11001001 S11001001 merged commit e13d962 into master Sep 24, 2019
@S11001001 S11001001 deleted the 3004-ddcify-json-api-docs branch September 24, 2019 20:41
@stefanobaghino-da stefanobaghino-da added component/json-api HTTP JSON API team/ledger-clients Related to the Ledger Clients team's components. labels Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/documentation component/json-api HTTP JSON API team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON API Documentation
4 participants