-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move ledger-service/http-json docs into docs.daml.com tree, summarize purpose #3012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏 Many thanks for getting it done so quickly even!
docs/source/json-api/index.rst
Outdated
|
||
:: | ||
|
||
$ daml-head sandbox --wall-clock-time --ledgerid MyLedger ./.daml/dist/quickstart-0.0.1.dar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the daml-head
references to just daml
.
@@ -213,9 +213,10 @@ quotes:: | |||
"Bob" | |||
|
|||
Unit | |||
---- | |||
**** | |||
|
|||
Represented as empty object ``{}``. Note that in JavaScript ``{} !== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backtick literals in this paragraph that are split across lines probably need to be joined back to start and end in the same line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I just accidentally added an empty line between them; renders fine after reverting that d2ef790
Fixes #3004.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.