Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing additional options to sandbox/navigator/json-api in d… #3002

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Support passing additional options to sandbox/navigator/json-api in d… #3002

merged 1 commit into from
Sep 24, 2019

Conversation

cocreature
Copy link
Contributor

…aml start

This should make daml start a bit more useful since you don’t have
to switch to starting all processes separately once you start
deviating from the defaults, e.g., I found myself wanting to specify a
custom ledger id during the hackathon. This is part 1 of ##2993.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature
Support passing additional options to sandbox/navigator/json-api in d…
263aa4f 
…aml start

This should make `daml start` a bit more useful since you don’t have
to switch to starting all processes separately once you start
deviating from the defaults, e.g., I found myself wanting to specify a
custom ledger id during the hackathon. This is part 1 of ##2993.
@cocreature cocreature requested a review from a user September 24, 2019 14:23
@cocreature cocreature requested a review from bame-da as a code owner September 24, 2019 14:23
hurryabit
hurryabit approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@cocreature cocreature merged commit 8ad74da into master Sep 24, 2019
ghost
ghost reviewed Sep 25, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@ghost ghost deleted the customized-daml-start branch September 25, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

@bame-da bame-da Awaiting requested review from bame-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @hurryabit