Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduce pkgname in damlc migrate from dalf not dar #3000

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

cocreature
Copy link
Contributor

The filename of the dar is not something that you should rely on as
evidenced by the fact that we have a -o option to change it to
something completely different.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

The filename of the dar is not something that you should rely on as
evidenced by the fact that we have a -o option to change it to
something completely different.
@cocreature cocreature requested review from a user and hurryabit September 24, 2019 13:49
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you.

@mergify mergify bot merged commit 1d593f2 into master Sep 24, 2019
@mergify mergify bot deleted the migrate-pkgname branch September 24, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants