Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daml-LF: change Numeric max scale from 38 to 37 #2969

Merged
merged 3 commits into from
Sep 23, 2019
Merged

Daml-LF: change Numeric max scale from 38 to 37 #2969

merged 3 commits into from
Sep 23, 2019

Conversation

remyhaemmerle-da
Copy link
Collaborator

This PR advances the Numeric implementation #2289.

In this PR we change the Numeric max scale from 38 to 37. We restrict the possible scale in this way, because we want 1 to be representable at any scale.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da force-pushed the daml-lf-numeric branch 3 times, most recently from c954ae9 to c4a6f7c Compare September 23, 2019 09:06
@remyhaemmerle-da remyhaemmerle-da changed the title Daml lf numeric Daml-LF: change Numeric max scale from 38 to 37 Sep 23, 2019
@remyhaemmerle-da remyhaemmerle-da requested a review from a user September 23, 2019 09:07
gerolf-da
gerolf-da approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also already change the numeric spec in the ledger api value.proto?

@remyhaemmerle-da
Copy link
Collaborator Author

@gerolf-da wrote:

Should we also already change the numeric spec in the ledger api value.proto?

Indeed. Good catch. Thanks.

I update both leger values.proto and daml_lf_1.proto

@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone Sep 23, 2019
@mergify mergify bot merged commit d540f7a into master Sep 23, 2019
@mergify mergify bot deleted the daml-lf-numeric branch September 23, 2019 12:39
hurryabit
hurryabit reviewed Sep 23, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit left review comments

@gerolf-da gerolf-da gerolf-da approved these changes

@leo-da leo-da Awaiting requested review from leo-da

@rautenrieth-da rautenrieth-da Awaiting requested review from rautenrieth-da

@S11001001 S11001001 Awaiting requested review from S11001001

@stefanobaghino-da stefanobaghino-da Awaiting requested review from stefanobaghino-da

Assignees
No one assigned
Labels
component/daml-lf DAML-LF
Projects
None yet
Milestone
Maintenance
Development

Successfully merging this pull request may close these issues.
3 participants
@remyhaemmerle-da @hurryabit @gerolf-da