Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore ledger updates that contain commands rejected due to de-duplication #2939

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

mziolekda
Copy link
Contributor

Ignore ledger updates that contain commands rejected due to de-duplication.
Such updates should not be entered into the index database as a) they are redundant and can be confusing b) could open a DOS attack vector.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@mziolekda mziolekda merged commit bf9ae04 into master Sep 18, 2019
@mziolekda mziolekda deleted the no-exception-on-command-rejection branch November 5, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants