Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contract key uniqueness check in kvutils #2933

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Fix contract key uniqueness check in kvutils #2933

merged 2 commits into from
Sep 17, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2019

Archival of a contract with a key and recreation within the
same transaction is now allowed in kvutils.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@ghost ghost requested a review from rautenrieth-da as a code owner September 17, 2019 12:10
gerolf-da
gerolf-da reviewed Sep 17, 2019
View reviewed changes
Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dajmaki. Would you mind expanding the test a tiny little bit with an assertion?

...er/ledger-api-test-tool/src/main/scala/com/daml/ledger/api/testtool/tests/ContractKeys.scala Outdated Show resolved Hide resolved
...er/ledger-api-test-tool/src/main/scala/com/daml/ledger/api/testtool/tests/ContractKeys.scala Outdated Show resolved Hide resolved
Jussi Maki added 2 commits September 17, 2019 17:12
Fix contract key uniqueness check in kvutils
0790dd4 
Archival of a contract with a key and recreation within the
same transaction is now allowed in kvutils.
Add assertions to check that new contract has been created with same key
beae767
@ghost ghost force-pushed the kvutils-fix-contract-key-uniqueness branch from cd56fe6 to beae767 Compare September 17, 2019 15:12
@mziolekda mziolekda merged commit 11f1735 into master Sep 17, 2019
@ghost ghost deleted the kvutils-fix-contract-key-uniqueness branch September 18, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mziolekda mziolekda Awaiting requested review from mziolekda

@rautenrieth-da rautenrieth-da Awaiting requested review from rautenrieth-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerolf-da @stefanobaghino-da @mziolekda