Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-0-13-24 #2922

Merged
merged 1 commit into from
Sep 16, 2019
Merged

release-0-13-24 #2922

merged 1 commit into from
Sep 16, 2019

Conversation

leo-da
Copy link
Contributor

@leo-da leo-da commented Sep 16, 2019 •
edited
Loading

The main reason is daml codegen command + fixing the quickstart-scala example and docs.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@leo-da leo-da requested a review from bame-da as a code owner September 16, 2019 16:22
rohanjr
rohanjr approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@rohanjr rohanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohanjr rohanjr removed the automerge label Sep 16, 2019
@rohanjr
Copy link
Contributor

rohanjr commented Sep 16, 2019

I will rebase after #2923 lands to get that fix into this release.

@rohanjr rohanjr merged commit b2b711c into master Sep 16, 2019
@rohanjr rohanjr deleted the release-0.13.24 branch September 16, 2019 19:19
@leo-da
Copy link
Contributor Author

leo-da commented Sep 16, 2019 •
edited
Loading

Summary:
I will not be making 0.13.24 pre-release public.

  1. quckstart-java does not compile until you remove ~/.m2 directory. Did not work on my Linux and on @rohanjr's Mac OSX until we wiped our ~/.m2.
  2. on Linux, daml studio --replace=always did not display Scenario results link above setup scenario in daml/Main.daml. VScode v1.38.0.

All other manual tests passed on Linux and Windows. BTW quickstart-java compilation worked on Windows, probably because nobody tried to build it on Windows and ~/.m2 was empty.

@leo-da
Copy link
Contributor Author

leo-da commented Sep 17, 2019 •
edited
Loading

  1. mvn -U addresses the quickstart-java compilation issue
  2. the issue with VSCode not displaying the Scenario results link was due to "editor.codeLens": false configured in settings.json, setting it to true displayed the link.

All manual tests have passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanjr rohanjr rohanjr approved these changes

@cocreature cocreature Awaiting requested review from cocreature

@rohanjr-da rohanjr-da Awaiting requested review from rohanjr-da

@bame-da bame-da Awaiting requested review from bame-da

Assignees
No one assigned
Labels
Standard-Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leo-da @rohanjr @nycnewman