Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daml-LF: Add CAST_NUMERIC and SHIFT_NUMERIC #2919

Merged
merged 7 commits into from
Sep 17, 2019
Merged

Daml-LF: Add CAST_NUMERIC and SHIFT_NUMERIC #2919

merged 7 commits into from
Sep 17, 2019

Conversation

remyhaemmerle-da
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da commented Sep 16, 2019 •
edited by gerolf-da
Loading

This PR advances the Numeric implementation #2289.

This PR introduces the Builtins CAST_NUMERIC and SHIFT_NUMERIC in the daml-lf side as describeb in #2289.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da added component/daml-engine DAML-LF Engine & Interpreter component/daml-lf DAML-LF labels Sep 16, 2019
@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone Sep 16, 2019
ghost
ghost approved these changes Sep 16, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

daml-lf/spec/daml-lf-1.rst Outdated Show resolved Hide resolved
gerolf-da
gerolf-da requested changes Sep 16, 2019
View reviewed changes
daml-lf/archive/da/daml_lf_1.proto Outdated Show resolved Hide resolved
@remyhaemmerle-da remyhaemmerle-da changed the title Daml lf numeric Daml-LF: Add CAST_NUMERIC and SHIFT_NUMERIC Sep 16, 2019
@mergify mergify bot merged commit dc9429b into master Sep 17, 2019
@mergify mergify bot deleted the daml-lf-numeric branch September 17, 2019 08:52
@hurryabit
Copy link
Contributor

Nice. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerolf-da gerolf-da gerolf-da approved these changes

@hurryabit hurryabit Awaiting requested review from hurryabit

@leo-da leo-da Awaiting requested review from leo-da

@S11001001 S11001001 Awaiting requested review from S11001001

Assignees
No one assigned
Labels
component/daml-engine DAML-LF Engine & Interpreter component/daml-lf DAML-LF
Projects
None yet
Milestone
Maintenance
Development

Successfully merging this pull request may close these issues.
3 participants
@remyhaemmerle-da @hurryabit @gerolf-da