Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger-service: fix numGen for scale 38 #2908

Merged
merged 1 commit into from
Sep 16, 2019
Merged

ledger-service: fix numGen for scale 38 #2908

merged 1 commit into from
Sep 16, 2019

Conversation

remyhaemmerle-da
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da commented Sep 16, 2019 •
edited
Loading

Quick fix for random generation numeric values of scale 38.
This PR is related to #2289.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

cocreature
cocreature approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@mergify mergify bot merged commit 249e8a6 into master Sep 16, 2019
@mergify mergify bot deleted the daml-lf-numeric branch September 16, 2019 10:18
@ghost
Copy link

ghost commented Sep 16, 2019

Relatedly, we had discussed limiting the scale to 37 before, so we can always represent the integer 1 (the multipliciative unit, munit). Not sure we should be generating scale 38 numerics at all.

hurryabit
hurryabit reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we agree that 38 is not allowed as a scale for now?

@remyhaemmerle-da
Copy link
Collaborator Author

We agreed Indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit left review comments

@cocreature cocreature cocreature approved these changes

@leo-da leo-da Awaiting requested review from leo-da

@S11001001 S11001001 Awaiting requested review from S11001001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remyhaemmerle-da @cocreature @hurryabit