Add a CPP flag for each available DAML-LF feature. #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
|
cocreature
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Awesome, I like how simple this has turned out! Also very much in favor of having feature flags instead of version flags, reminds me of https://github.com/quchen/articles/blob/master/haskell-cpp-compatibility.md in a good way 🙂
hurryabit
reviewed
Sep 18, 2019
| @@ -199,7 +199,7 @@ _whenRuntimeSupports version feature t e | |||
| | otherwise = runtimeUnsupported feature t | |||
|
|
|||
| runtimeUnsupported :: Feature -> Type -> Expr | |||
| runtimeUnsupported (Feature name version) t = | |||
| runtimeUnsupported (Feature name version _) t = | |||
There was a problem hiding this comment.
We should be able to remove this function now. This was our old hack around the fact that the stdlib could not depend on the DAML-LF version we're compiling to.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99. This PR adds CPP flags for each DAML-LF feature declared in
DA.Daml.LF.Version. The CPP flag is only passed when compiling to a DAML-LF version that supports that feature.Right now, it only adds the
DAML_NUMERICCPP flag which will be used in the standard library implementation of Numeric types (see #2289). The advantage of doing things this way is that the mapping between features and versions is kept in a central location (DA.Daml.LF.Version), so they only need to be updated there.