Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language: update of migrate docu #2863

Merged
1 commit merged into from
Sep 10, 2019
Merged

language: update of migrate docu #2863

1 commit merged into from
Sep 10, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 10, 2019

The number of arguments to the migrate command changed since we don't
need a project main file anymore.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

language: update of migrate docu
da69646 
The number of arguments to the migrate command changed since we don't
need a project main file anymore.
@ghost ghost requested a review from bame-da as a code owner September 10, 2019 13:54
bame-da
bame-da approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@bame-da bame-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ghost ghost merged commit 07d1930 into master Sep 10, 2019
@ghost ghost deleted the migrate_docu_fix branch September 10, 2019 14:25
hurryabit
hurryabit reviewed Sep 10, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DAML Packaging & Deployment UX
Development

Successfully merging this pull request may close these issues.
2 participants
@hurryabit @bame-da