Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2326, GHC 8.4 compatibility #2796

Merged
merged 6 commits into from
Sep 7, 2019
Merged

#2326, GHC 8.4 compatibility #2796

merged 6 commits into from
Sep 7, 2019

Conversation

ndmitchell
Copy link
Contributor

Fixed it up. After that, hie-core built with GHC 8.4 can compile hie-core.

I also added a message about which GHC you used on startup, since that seems to be a common mistake people are making.

cocreature
cocreature approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@cocreature
Copy link
Contributor

It would be great if you could also add a stack.yaml file for 8.4. That should make it easy to add a CI job to make sure we don’t break this again.

@cocreature
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@cocreature
Copy link
Contributor

CI is failing due to hlint.

@ndmitchell
Copy link
Contributor Author

Added a stack84.yaml, so now you can successfully run:

C:\Neil\daml\compiler\hie-core>stack build --stack-yaml stack84.yaml && stack test --stack-yaml stack84.yaml

Also fixed the HLint errors and a warning.

@cocreature
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@cocreature
Copy link
Contributor

Thanks for the updates! HLint is sadly, still unhappy. I recommend that you run the fmt.sh script in the project root to verify things.

@ndmitchell
Copy link
Contributor Author

Fixed HLint (I didn't have it installed on this machine...)

@cocreature
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@ndmitchell
Copy link
Contributor Author 

//ledger/sandbox:sandbox-scala-tests_test_suite_src_test_suite_scala_com_digitalasset_platform_sandbox_ScenarioLoadingITPostgres.scala FAILED in 27.0s

Looks like a flake.

@cocreature cocreature merged commit bdcbf16 into digital-asset:master Sep 7, 2019
@ndmitchell ndmitchell deleted the ghc84 branch September 7, 2019 14:51
@ndmitchell ndmitchell mentioned this pull request Sep 10, 2019
Closed
hsenag pushed a commit to hsenag/daml that referenced this pull request Sep 13, 2019
@ndmitchell @garyverhaegen-da
digital-asset#2326, GHC 8.4 compatibility (digital-asset#2796)
9bd7885 
* digital-asset#2326, GHC 8.4 compatibility

* Fix up CI

* Add a Shake lower bound

* Upgrade to a hie-bios which is GHC 8.4 compatible

* Add a GHC 8.4 stack

* Fix HLint again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndmitchell @cocreature