Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restriction on child_event_ids #2783

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Fix restriction on child_event_ids #2783

merged 1 commit into from
Sep 6, 2019

Conversation

cocreature
Copy link
Contributor

Unless I am missing something fundamental here all event_ids are
LedgerStrings not PartyIdStrings.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Unless I am missing something fundamental here all event_ids are
LedgerStrings not PartyIdStrings.
@gerolf-da
Copy link
Contributor

Thanks, @cocreature 👍

@cocreature cocreature merged commit 402ae2a into master Sep 6, 2019
@garyverhaegen-da garyverhaegen-da deleted the fix-childev-format branch February 9, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants