Rename referencedContracts to divulgedContracts #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
meiersi-da,
gerolf-da,
rautenrieth-da and
andreaslochbihler-da
ghost
added
the
ghost
force-pushed
the
rename-referencedcontracts
branch
from
e6f2219 to
24239e4
Compare
added 3 commits
September 5, 2019 12:59
We do not want to provide all referenced contracts as that would require the ReadService to be able to read all those contracts, or we would need to bundle the referenced contracts with the transaction. The new type should match what was discussed in #2488.
We decided not to prematurely add this feature.
cocreature
force-pushed
the
rename-referencedcontracts
branch
from
24239e4 to
7360310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want to provide all referenced contracts as that would
require the ReadService to be able to read all those contracts, or
we would need to bundle the referenced contracts with the transaction.
The new type should match what was discussed in #2488.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.