Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ghc-lib, improving parsing of template headers #2609

Merged
merged 4 commits into from
Aug 20, 2019
Merged

Upgrade ghc-lib, improving parsing of template headers #2609

merged 4 commits into from
Aug 20, 2019

Conversation

rohanjr
Copy link
Contributor

@rohanjr rohanjr commented Aug 20, 2019 •
edited
Loading

See digital-asset/ghc#34. This allows a greater number of contexts in generic templates.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@rohanjr rohanjr requested review from hurryabit and a user August 20, 2019 15:48
@rohanjr rohanjr self-assigned this Aug 20, 2019
ghost
ghost approved these changes Aug 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting!

hurryabit
hurryabit approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like tests. Thanks a lot.

@rohanjr rohanjr merged commit 4c53841 into master Aug 20, 2019
@rohanjr rohanjr deleted the ghc-lib-parsing branch August 20, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

Assignees

@rohanjr rohanjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanjr @hurryabit