engine: SDecimal -> SNumeric #2577
Merged
+153
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
force-pushed
the
daml-lf-numeric-2
branch
2 times, most recently
from
c70a01a to
83dcef0
Compare
gerolf-da
approved these changes
Aug 16, 2019
remyhaemmerle-da
force-pushed
the
daml-lf-numeric-2
branch
from
83dcef0 to
4e37c03
Compare
remyhaemmerle-da
force-pushed
the
daml-lf-numeric-2
branch
from
4e37c03 to
5d094d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the effort to implement variable scaled Numeric type (See #2289)
This substitutes Decimal by Numeric (delivered in #2556) in the engine internals
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.