LedgerClient JWT pass-through in the HTTP JSON API gateway #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not integrated with HTTP JSON API gateway yet.
leo-da
requested review from
rautenrieth-da and
stefanobaghino-da
as code owners
|
Supposed to be draft |
leo-da
changed the title
|
Can't re-open it as draft without deleting the branch... too much hassle. |
leo-da
changed the title
S11001001
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #2523
the starting points for the review:
com.digitalasset.http.LedgerClientJwt#forChannelcom.digitalasset.http.LedgerClientJwt#SubmitAndWaitForTransactioncom.digitalasset.http.LedgerClientJwt#GetActiveContractsPull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.