-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daml-lf: Core type Numeric #2556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
added
component/daml-engine
DAML-LF Engine & Interpreter
component/daml-lf
DAML-LF
labels
Aug 15, 2019
remyhaemmerle-da
force-pushed
the
daml-lf-numeric-2
branch
from
August 15, 2019 11:30
54811ba
to
808a03e
Compare
gerolf-da
requested changes
Aug 15, 2019
daml-lf/data/src/main/scala/com/digitalasset/daml/lf/data/NumericModule.scala
Outdated
Show resolved
Hide resolved
daml-lf/data/src/main/scala/com/digitalasset/daml/lf/data/NumericModule.scala
Outdated
Show resolved
Hide resolved
daml-lf/data/src/main/scala/com/digitalasset/daml/lf/data/NumericModule.scala
Show resolved
Hide resolved
daml-lf/data/src/main/scala/com/digitalasset/daml/lf/data/NumericModule.scala
Outdated
Show resolved
Hide resolved
daml-lf/data/src/main/scala/com/digitalasset/daml/lf/data/NumericModule.scala
Outdated
Show resolved
Hide resolved
daml-lf/data/src/main/scala/com/digitalasset/daml/lf/data/NumericModule.scala
Outdated
Show resolved
Hide resolved
daml-lf/data/src/test/scala/com/digitalasset/daml/lf/data/NumericSpec.scala
Outdated
Show resolved
Hide resolved
daml-lf/data/src/test/scala/com/digitalasset/daml/lf/data/NumericSpec.scala
Outdated
Show resolved
Hide resolved
daml-lf/data/src/test/scala/com/digitalasset/daml/lf/data/NumericSpec.scala
Outdated
Show resolved
Hide resolved
daml-lf/data/src/test/scala/com/digitalasset/daml/lf/data/NumericSpec.scala
Outdated
Show resolved
Hide resolved
Co-Authored-By: Gerolf Seitz <gerolf.seitz@digitalasset.com>
remyhaemmerle-da
force-pushed
the
daml-lf-numeric-2
branch
from
August 15, 2019 12:53
80c60ac
to
7c2b880
Compare
in particular add tests for round and toLong
remyhaemmerle-da
force-pushed
the
daml-lf-numeric-2
branch
from
August 15, 2019 12:55
7c2b880
to
345fe4d
Compare
gerolf-da
approved these changes
Aug 16, 2019
This was referenced Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the effort to implement variable scaled Numeric type (See #2289)
This defined the core type and core functions for handle Numeric.
It is currently no plug to the rest of the code, this will be done in an upcoming PR.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.