Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daml-lf: Core type Numeric #2556

Merged
merged 4 commits into from
Aug 16, 2019
Merged

Daml-lf: Core type Numeric #2556

merged 4 commits into from
Aug 16, 2019

Conversation

remyhaemmerle-da
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da commented Aug 15, 2019

This PR is part of the effort to implement variable scaled Numeric type (See #2289)

This defined the core type and core functions for handle Numeric.
It is currently no plug to the rest of the code, this will be done in an upcoming PR.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Co-Authored-By: Gerolf Seitz <gerolf.seitz@digitalasset.com>
in particular add tests for round and toLong
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/daml-engine DAML-LF Engine & Interpreter component/daml-lf DAML-LF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants